I often told you we'd go there when
spring arrives. That sentence seems
funny to me. It means that in the past
the speaker would often promise the
listener that when spring arrives they
would go to a certain place together.
Is it grammatically correct?
What about these alternatives?
I often told you we'd go there when
spring arrived. I'm not sure if
"arrives" or "arrived" should be used.
This is an example of a report of some previous speech. It is a common misconception in English that "tenses must match", that we have rules for tense concord. That's not true. If it was true, then there would be certain things that we couldn't express.
Yes, it is grammatically correct. The timing, that is, when the sentence is spoken, could render either 'arrives' or 'arrived' semantically odd.
In English, to mark speech as reported [not direct], we can and often do a 'backshift' which means that we drop one tense into the past, NOT as a marker of true tense/time shifting but solely to indicate that the speech isn't a direct quote.
If we wanted to reassure, we might even choose,
I often tell you [do I not?] that we will go there when spring arrives.
Mother: [to child] We will go there when spring arrives.
Child: [later relating this to friends] My mom told me [that] we will/would go there when spring arrived/arrives.
As we can see, there is a choice. We can backshift to mark it as indirect/reported speech, or as we often do, or actually not do, we don't backshift when the event is still current, still to be.
The problem comes when people think that because 'told', the reporting verb is in the past tense, that everything else has to match. But this is false. The reason that 'told' and other reporting verbs are in the past is because that has actually finished. The remainder of the speech is often not finished, it is still to come.
So, again, the switch to past tense FORM, which is a grammatical function unrelated to an actual tense/time shift, is done for the sole purpose of marking speech as indirect/reported.